Bug 40157 – Web Inspector: CSS style closing brace is not selectable.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ilya Tikhonovsky]

%SUBJ%

[Nikita Vasilyev]

Created attachment 58363 [details]
<div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it.

[Pavel Feldman]

Comment on attachment 58363 [details]
<div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it.

WebCore/inspector/front-end/inspector.css:3981
 +  .styles-selector, .close-brace {
I think we should add -webkit-user-select: text to .styles-section instead.

[Nikita Vasilyev]

Created attachment 58368 [details]
Selectable brace

Yes, it works the same.

[Pavel Feldman]

Comment on attachment 58368 [details]
Selectable brace

(You should have removed it from the header now that it is set on the parent element).

[Nikita Vasilyev]

Created attachment 58371 [details]
Selectable brace

[Pavel Feldman]

Comment on attachment 58371 [details]
Selectable brace

Thanks!

[WebKit Commit Bot]

Comment on attachment 58371 [details]
Selectable brace

Rejecting patch 58371 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 58371, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=58371&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=40157&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 58371 from bug 40157.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Joseph Pecoraro]

Nice!

Looks like the cq  didn't land because its missing the line to fill in for the reviewer. Using `prepare-ChangeLog` will put in the right template and prevent this error. This is missing the "Reviewed by (OOPS)" line or whatever.

I can manually add that line in and land this patch tomorrow. Or someone can beat me to it!

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.css
Committed r61009