Bug 40146

Summary:

Geolocation needs more LayoutTests to test making callbacks to remote frames

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, eric, jorlow, steveblock, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Steve Block

Reported 2010-06-03 15:39:39 PDT

Bug 40129 added a layout test to test making a callback from a Geolocation object to a remote frame. In this case, the JavaScript call chain was initiated from the frame owning the Geolocation object. We should add a similar test where the call chain is initiated from the remote frame. See https://bugs.webkit.org/show_bug.cgi?id=40129#c8

Attachments
Patch (3.64 KB, patch) 2010-06-04 02:43 PDT, Steve Block	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-06-04 02:43:54 PDT

Created attachment 57858 [details] Patch

Jeremy Orlow

Comment 2 2010-06-04 02:52:26 PDT

Comment on attachment 57858 [details] Patch r=me If you'd like, feel free to make a patch with more than one test.

Steve Block

Comment 3 2010-06-04 02:57:52 PDT

Committed r60669: <http://trac.webkit.org/changeset/60669>

WebKit Review Bot

Comment 4 2010-06-04 03:22:38 PDT

http://trac.webkit.org/changeset/60669 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/60669 http://trac.webkit.org/changeset/60670

Steve Block

Comment 5 2010-06-04 03:46:40 PDT

Comment on attachment 57858 [details] Patch Added callback-to-remote-context2.html to the GTK skipped list in r60672, http://trac.webkit.org/changeset/60672 and updated Bug 40153

Note You need to log in before you can comment on or make changes to this bug.