Summary: | PDF files by default load with a poor choice of sizing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Trey Matteson <trey> | ||||||
Component: | New Bugs | Assignee: | Trey Matteson <trey> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Enhancement | ||||||||
Priority: | P2 | ||||||||
Version: | 412 | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
URL: | http://www.copyright.gov/legislation/dmca.pdf | ||||||||
Attachments: |
|
Description
Trey Matteson
2005-07-15 12:58:20 PDT
I think making the UI settings sticky is a good idea. This could be implemented by adding preferences to WebPreferences that start out at the initial PDFKit settings. These preferences would be used whenever WebPDFView loads a document, and would be altered whenever the user chooses from the context menu. Ideally pages in the back/forward list would continue to be displayed with their original settings when revisited in the b/f list. Also, I think that ideally reloading would not affect the settings for the displayed page (that is, it wouldn't reload using prefs values that had changed since it was first loaded), but getting this exactly right could be treated as a separate, lower-importance bug I think. I am likely to take a crack at this. Created attachment 3188 [details]
proposed patch
For this round the UI is simply that changes to the PDF viewing params are
sticky.
Comment on attachment 3188 [details]
proposed patch
Trey and I discussed a couple of tweaks on IRC, so I'm giving this version a
review-
Created attachment 3195 [details]
patch corrected per review
Comment on attachment 3195 [details]
patch corrected per review
I'll check this in.
checked in |