Bug 40126

Summary: [Chromium] Add 'setJavaScriptProfilingEnabled' to WebDevToolsAgent, so it can be added to LayoutTestController
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Status: RESOLVED WONTFIX    
Severity: Normal CC: pfeldman, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
mnaganov: commit-queue-
untabify changelog mnaganov: review-, mnaganov: commit-queue-

Description Mikhail Naganov 2010-06-03 09:38:27 PDT
This is needed for compatibility with WebKit's layout tests.
Comment 1 Mikhail Naganov 2010-06-03 09:40:36 PDT
Created attachment 57781 [details]
patch
Comment 2 WebKit Review Bot 2010-06-03 09:41:48 PDT
Attachment 57781 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebKit/chromium/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mikhail Naganov 2010-06-03 09:44:24 PDT
Created attachment 57782 [details]
untabify changelog
Comment 4 Mikhail Naganov 2010-06-03 09:55:45 PDT
This is not needed. JS profiling is always enabled in Chromium's InspectorController, so LTC's method can be dummy.