Bug 40098 – [chromium] generate DumpRenderTree.pak on DRT linux

• Component: New Bugs
• Status: RESOLVED FIXED

[Tony Chang]

[chromium] generate DumpRenderTree.pak on DRT linux

[Tony Chang]

Created attachment 57726 [details]
Patch

[Kent Tamura]

Comment on attachment 57726 [details]
Patch

WebKit/chromium/WebKit.gyp:643
 +                  ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
nit: Add "solaris" too?

[Tony Chang]

Committed r60596: <http://trac.webkit.org/changeset/60596>

[Tony Chang]

(In reply to comment #2)
> (From update of attachment 57726 [details])
> WebKit/chromium/WebKit.gyp:643
>  +                  ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
> nit: Add "solaris" too?


Good idea, fixed before landing.

[Kent Tamura]

Comment on attachment 57726 [details]
Patch

WebKit/chromium/WebKit.gyp:662
 +                                  'repack_path': './tools/data_pack/repack.py',
This path doesn't work in Chromium tree.
Could you fix it please?

[Tony Chang]

(In reply to comment #5)
> (From update of attachment 57726 [details])
> WebKit/chromium/WebKit.gyp:662
>  +                                  'repack_path': './tools/data_pack/repack.py',
> This path doesn't work in Chromium tree.
> Could you fix it please?

Yes, sorry, I just submitted http://trac.webkit.org/changeset/60607 for this.  I think we can merge the mac & linux code for this as well.  I will try it.

[Kent Tamura]

Thank you for the quick fix!