| Summary: | Set attributes.stencil to false by default at context creation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zhenyao Mo <zmo> | ||||
| Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarrin, commit-queue, kbr, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Zhenyao Mo
2010-06-02 17:02:57 PDT
This requires a WebGL specification change, but one which has basically already been agreed upon by the WebGL working group. Created attachment 57718 [details]
patch
(In reply to comment #2) > Created an attachment (id=57718) [details] > patch This looks okay, but it must not be committed until the associated changes have been made to the WebGL spec. I'll try to get this approved by the working group tomorrow morning. Are all of the other WebGL layout tests working with this change? In other words, there weren't any others dependent on the previous default of stencil=true? Yes, all the tests pass with this change. Comment on attachment 57718 [details]
patch
Please set the r?/cq? when "the associated changes have been made to the WebGL spec" since "it must not be committed until" then.
Until then it is just cluttering a really full review queue and nothing can be done for it.
The WebGL spec has been updated to indicate that the default value of the stencil flag is false. The patch looks good to me. Comment on attachment 57718 [details]
patch
ok.
Comment on attachment 57718 [details] patch Clearing flags on attachment: 57718 Committed r60660: <http://trac.webkit.org/changeset/60660> All reviewed patches have been landed. Closing bug. |