Bug 40088

Summary: webkit-patch should use a different editor env variable to avoid conflicting with prepare-ChangeLog
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED WONTFIX    
Severity: Normal CC: darin, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Adam Barth
Reported 2010-06-02 16:26:34 PDT
webkit-patch should use a different editor env variable to avoid conflicting with prepare-ChangeLog
Attachments
Patch (2.21 KB, patch)
2010-06-02 16:29 PDT, Adam Barth 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-02 16:29:35 PDT
Created attachment 57714 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-02 16:35:26 PDT
Comment on attachment 57714 [details] Patch Why is it _APPLICATION? Seems should just be _EDITOR since it's actually a terminal program. xed --launch --wait just is a terminal program which watches XCode. Otherwise LGTM.
Eric Seidel (no email)
Comment 3 2010-09-02 13:50:07 PDT
Status?
Adam Barth
Comment 4 2010-09-02 16:02:14 PDT
I need to address your comments and upload a new version.
Eric Seidel (no email)
Comment 5 2011-01-21 01:37:50 PST
3-month ping. :)
Adam Barth
Comment 6 2011-06-17 22:58:08 PDT
Looks like we don't care enough about this patch to land it. If I'm wrong, please feel free to re-open.
Note You need to log in before you can comment on or make changes to this bug.