Bug 40078

Summary:

[Qt] QtTestLauncher should allow notifications by default.

Product:

WebKit

Reporter:

Yael <yael>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

hausmann, kbalazs, laszlo.gombos, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

39995

Attachments:

Description	Flags
Patch	hausmann: review+

Yael

Reported 2010-06-02 12:22:15 PDT

QtWebKit does not allow notifications to be displayed, unless the client of QtWebKit explicitly allows them. For testing purpose, QtTestLauncher should allow notifications to be displayed.

Attachments
Patch (2.19 KB, patch) 2010-06-03 09:51 PDT, Yael	hausmann: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Balazs Kelemen

Comment 1 2010-06-03 04:32:54 PDT

As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case.

Yael

Comment 2 2010-06-03 04:48:27 PDT

(In reply to comment #1) > As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case. I disagree :-) #39995 is a meta tag that lists everything I plan to do for notifications. This bug is one of the tasks I am planning to do for notifications, thus the meta bug depends on this one.

Yael

Comment 3 2010-06-03 09:51:45 PDT

Created attachment 57784 [details] Patch

Kenneth Rohde Christiansen

Comment 4 2010-06-03 10:03:37 PDT

Comment on attachment 57784 [details] Patch It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead?

Yael

Comment 5 2010-06-03 10:27:58 PDT

(In reply to comment #4) > (From update of attachment 57784 [details]) > It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead? It seems strage to me too :-) Once the feature is more mature we should think about what public API we want to provide for it.

Simon Hausmann

Comment 6 2010-06-04 06:00:14 PDT

Comment on attachment 57784 [details] Patch r=me Using it in QtTestBrowser is perhaps a good way to test and maturize the API. The current one is not designed to be public. As a side-note: This patch is going to break the symbian build, as these DRT symbols are not exported.

Yael

Comment 7 2010-06-04 06:51:50 PDT

Committed r60678 <http://trac.webkit.org/changeset/60678>

Laszlo Gombos

Comment 8 2010-06-04 10:12:16 PDT

Updated the def file for Symbian - http://trac.webkit.org/changeset/60686

Simon Hausmann

Comment 9 2010-08-03 08:33:03 PDT

Revision r60678 cherry-picked into qtwebkit-2.1 with commit 720c83fa263ba3d2ce4867c118efcf646613d20b

Note You need to log in before you can comment on or make changes to this bug.