| Summary: | [Qt] QtTestLauncher should allow notifications by default. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yael <yael> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | hausmann, kbalazs, laszlo.gombos, ossy | ||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 39995 | ||||||
| Attachments: |
|
||||||
|
Description
Yael
2010-06-02 12:22:15 PDT
As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case. (In reply to comment #1) > As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case. I disagree :-) #39995 is a meta tag that lists everything I plan to do for notifications. This bug is one of the tasks I am planning to do for notifications, thus the meta bug depends on this one. Created attachment 57784 [details]
Patch
Comment on attachment 57784 [details]
Patch
It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead?
(In reply to comment #4) > (From update of attachment 57784 [details]) > It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead? It seems strage to me too :-) Once the feature is more mature we should think about what public API we want to provide for it. Comment on attachment 57784 [details]
Patch
r=me
Using it in QtTestBrowser is perhaps a good way to test and maturize the API. The current one is not designed to be public.
As a side-note: This patch is going to break the symbian build, as these DRT symbols are not exported.
Committed r60678 <http://trac.webkit.org/changeset/60678> Updated the def file for Symbian - http://trac.webkit.org/changeset/60686 |