|Summary:||[Qt] QtTestLauncher should allow notifications by default.|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Enhancement||CC:||hausmann, kbalazs, laszlo.gombos, ossy|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Yael 2010-06-02 12:22:15 PDT
QtWebKit does not allow notifications to be displayed, unless the client of QtWebKit explicitly allows them. For testing purpose, QtTestLauncher should allow notifications to be displayed.
Comment 1 Balazs Kelemen 2010-06-03 04:32:54 PDT
As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case.
Comment 2 Yael 2010-06-03 04:48:27 PDT
(In reply to comment #1) > As I see the notifications API does not depend on that. On the contrary, this feature depends on the API. Please correct the dependency tree if that is the case. I disagree :-) #39995 is a meta tag that lists everything I plan to do for notifications. This bug is one of the tasks I am planning to do for notifications, thus the meta bug depends on this one.
Comment 4 Kenneth Rohde Christiansen 2010-06-03 10:03:37 PDT
Comment on attachment 57784 [details] Patch It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead?
Comment 5 Yael 2010-06-03 10:27:58 PDT
(In reply to comment #4) > (From update of attachment 57784 [details]) > It seems a bit strange to use DRT methods in our launcher. Are these methods supposed to be private (later public) API instead? It seems strage to me too :-) Once the feature is more mature we should think about what public API we want to provide for it.
Comment 6 Simon Hausmann 2010-06-04 06:00:14 PDT
Comment on attachment 57784 [details] Patch r=me Using it in QtTestBrowser is perhaps a good way to test and maturize the API. The current one is not designed to be public. As a side-note: This patch is going to break the symbian build, as these DRT symbols are not exported.
Comment 8 Laszlo Gombos 2010-06-04 10:12:16 PDT
Updated the def file for Symbian - http://trac.webkit.org/changeset/60686