|Summary:||[Qt] The QScriptValuePrivate::CSpecial is too generic.|
|Product:||WebKit||Reporter:||Jędrzej Nowacki <jedrzej.nowacki>|
|Severity:||Normal||CC:||commit-queue, jedrzej.nowacki, kenneth|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Jędrzej Nowacki 2010-06-02 09:26:57 PDT
The QScriptValuePrivate::CSpecial should be divided into a separate states; CNull and CUndefined. It would simplify the QScriptValue's design and implementation which should use the m_state member for distinguish between states not m_value.
Comment 1 Jędrzej Nowacki 2010-06-02 09:35:37 PDT
Created attachment 57663 [details] Fix v1 No functional changes.
Comment 2 Kenneth Rohde Christiansen 2010-06-02 11:44:23 PDT
Comment 3 Jędrzej Nowacki 2010-06-03 00:16:46 PDT
Comment 4 WebKit Commit Bot 2010-06-03 22:57:52 PDT
Comment on attachment 57663 [details] Fix v1 Clearing flags on attachment: 57663 Committed r60655: <http://trac.webkit.org/changeset/60655>
Comment 5 WebKit Commit Bot 2010-06-03 22:57:58 PDT
All reviewed patches have been landed. Closing bug.