Bug 40057

Summary:

IDL bindings should throw TypeError when called with too few arguments

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

benjamin, darin, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

39962

Attachments:

Description	Flags
Proposed patch	sam: review-

Andreas Kling

Reported 2010-06-02 06:49:56 PDT

See Web IDL spec, 4.3.5 "Operations": http://www.w3.org/TR/WebIDL/#es-operations Essentially, functions should throw a TypeError if called with too few arguments. This behavior is implemented by Gecko and Opera.

Attachments
Proposed patch (224.20 KB, patch) 2010-06-02 06:57 PDT, Andreas Kling	sam: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2010-06-02 06:57:09 PDT

Created attachment 57649 [details] Proposed patch First stab at a patch.

Sam Weinig

Comment 2 2010-06-02 08:22:12 PDT

Comment on attachment 57649 [details] Proposed patch We have made a conscious decision not throw for two few arguments and we should a much larger discussion if we want to change that behavior. It is very likely that this will break a lot of webkit specific code paths on web. r-

Andreas Kling

Comment 3 2010-06-02 08:43:10 PDT

(In reply to comment #2) > (From update of attachment 57649 [details]) > We have made a conscious decision not throw for two few arguments and we should a much larger discussion if we want to change that behavior. I see. Where can I find the original discussion about this?

Darin Adler

Comment 4 2010-06-02 10:38:54 PDT

*** This bug has been marked as a duplicate of bug 21257 ***

Note You need to log in before you can comment on or make changes to this bug.