Bug 40040

Summary: Web Inspector: Timeline should nicely format the Timer timeout
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Use Number.secondsToString none

Joseph Pecoraro
Reported 2010-06-01 21:12:35 PDT
Given the following: setTimeout(function(){}, 15000); I expected to see "15s" in the info bubble for the Timer on the Timeline panel. Instead I saw the unitless 15000. Is this worth testing? Its just a matter of applying the number formatter.
Attachments
[PATCH] Use Number.secondsToString (1.54 KB, patch)
2010-06-01 21:15 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-06-01 21:15:18 PDT
Created attachment 57618 [details] [PATCH] Use Number.secondsToString I like this formatter, because it will turn 15000 into 15s. However, it does round. So 12345 becomes 12.35s.
WebKit Commit Bot
Comment 2 2010-06-02 02:54:40 PDT
Comment on attachment 57618 [details] [PATCH] Use Number.secondsToString Clearing flags on attachment: 57618 Committed r60552: <http://trac.webkit.org/changeset/60552>
WebKit Commit Bot
Comment 3 2010-06-02 02:54:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.