Bug 40022

Summary: [chromium] Convert shaders used by the GL compositor to use GLSL ES
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, fishd, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch none

Vangelis Kokkevis
Reported 2010-06-01 13:07:35 PDT
Currently fragment shaders used by LayerRendererChromium are not valid GLSL ES shaders as they don't supply a precision qualifier. The GPU process has recently been modified to only accept GLSL ES shaders.
Attachments
Proposed patch (2.77 KB, patch)
2010-06-01 13:41 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2010-06-01 13:41:23 PDT
Created attachment 57591 [details] Proposed patch
WebKit Commit Bot
Comment 2 2010-06-02 01:18:40 PDT
Comment on attachment 57591 [details] Proposed patch Clearing flags on attachment: 57591 Committed r60545: <http://trac.webkit.org/changeset/60545>
WebKit Commit Bot
Comment 3 2010-06-02 01:18:45 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2010-06-02 02:50:38 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/60545 might have broken Qt Linux Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/60544 > http://trac.webkit.org/changeset/60545 > http://trac.webkit.org/changeset/60546 > http://trac.webkit.org/changeset/60547 > http://trac.webkit.org/changeset/60543 This patch is innocent, another one is the culprit, sorry for the SPAM.
Note You need to log in before you can comment on or make changes to this bug.