Bug 39968

Summary: [Qt] Shared platform plugin
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: New BugsAssignee: Luiz Agostini <luiz>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, kenneth, laszlo.gombos, yael
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39970, 40005    
Attachments:
Description Flags
patch 1
none
patch 2
none
patch 3
none
patch 4 none

Luiz Agostini
Reported 2010-05-31 13:44:13 PDT
Current implementation does not allow many instances of QtPlatformPlugin to share the QWebKitPlatformPlugin object provided by the plugin.
Attachments
patch 1 (4.19 KB, patch)
2010-05-31 13:51 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 2 (6.59 KB, patch)
2010-06-01 12:15 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 3 (6.96 KB, patch)
2010-06-02 13:35 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 4 (7.01 KB, patch)
2010-06-02 13:48 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-05-31 13:51:22 PDT
Created attachment 57493 [details] patch 1
Luiz Agostini
Comment 2 2010-06-01 12:15:29 PDT
Created attachment 57577 [details] patch 2
Laszlo Gombos
Comment 3 2010-06-01 14:04:12 PDT
load() could be expensive in a slow filesystem. It would be better not to go trough load() for each QtPlatformPlugin instance if they would refer the same plugin anyway.
Luiz Agostini
Comment 4 2010-06-02 13:35:58 PDT
Created attachment 57693 [details] patch 3
Luiz Agostini
Comment 5 2010-06-02 13:48:14 PDT
Created attachment 57696 [details] patch 4
Kenneth Rohde Christiansen
Comment 6 2010-06-02 14:00:12 PDT
Simon, what is the reason for the cq-?
Simon Hausmann
Comment 7 2010-06-02 14:05:22 PDT
Comment on attachment 57696 [details] patch 4 Wrong click on my side :)
WebKit Commit Bot
Comment 8 2010-06-02 19:38:09 PDT
Comment on attachment 57696 [details] patch 4 Clearing flags on attachment: 57696 Committed r60593: <http://trac.webkit.org/changeset/60593>
WebKit Commit Bot
Comment 9 2010-06-02 19:38:15 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 10 2010-06-04 00:51:05 PDT
Removing from the 2.0 patch blocker. This feature is not part of the 2.0 branch.
Simon Hausmann
Comment 11 2010-08-03 08:45:51 PDT
Revision r60593 cherry-picked into qtwebkit-2.1 with commit 38fcdf0bf780edfcf4052f08984447b5fced0c3f
Note You need to log in before you can comment on or make changes to this bug.