Bug 39952

Summary: [v8] Web Inspector: allow hiding Scripts panel from Chromium code
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: New BugsAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: loislo, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch that I'm going to land. pfeldman: review+

Yury Semikhatsky
Reported 2010-05-31 05:51:07 PDT
[v8] Web Inspector: allow hiding Scripts panel from Chromium code
Attachments
Patch (7.90 KB, patch)
2010-05-31 05:58 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch that I'm going to land. (7.91 KB, patch)
2010-05-31 07:10 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-05-31 05:58:58 PDT
Created attachment 57457 [details] Patch
Pavel Feldman
Comment 2 2010-05-31 07:08:17 PDT
Comment on attachment 57457 [details] Patch WebKit/chromium/public/WebDevToolsFrontendClient.h:45 + virtual void sendDebuggerPauseScript() {} missed it! WebKit/chromium/public/WebDevToolsFrontendClient.h:52 + virtual bool hideScriptsPanel() { return false; } shouldHideScriptsPanel
Yury Semikhatsky
Comment 3 2010-05-31 07:10:40 PDT
Created attachment 57460 [details] Patch that I'm going to land.
Yury Semikhatsky
Comment 4 2010-05-31 07:11:26 PDT
(In reply to comment #2) > (From update of attachment 57457 [details]) > WebKit/chromium/public/WebDevToolsFrontendClient.h:45 > + virtual void sendDebuggerPauseScript() {} > missed it! > Fixed. > WebKit/chromium/public/WebDevToolsFrontendClient.h:52 > + virtual bool hideScriptsPanel() { return false; } > shouldHideScriptsPanel Done.
Yury Semikhatsky
Comment 5 2010-05-31 07:36:53 PDT
Committed r60436
Note You need to log in before you can comment on or make changes to this bug.