Bug 39913

Summary: [chromium API] Expose html5 parser enable flag
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch fishd: review+, commit-queue: commit-queue-

James Robinson
Reported 2010-05-28 16:23:30 PDT
[chromium API] Expose html5 parser enable flag
Attachments
Patch (2.34 KB, patch)
2010-05-28 16:31 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2010-05-28 16:34 PDT, James Robinson 		fishd: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-05-28 16:29:41 PDT
*** Bug 39914 has been marked as a duplicate of this bug. ***
James Robinson
Comment 2 2010-05-28 16:31:27 PDT
Created attachment 57393 [details] Patch
James Robinson
Comment 3 2010-05-28 16:34:24 PDT
Created attachment 57394 [details] Patch
WebKit Commit Bot
Comment 4 2010-05-29 14:04:05 PDT
Comment on attachment 57394 [details] Patch Rejecting patch 57394 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--force']" exit_code: 1 Last 500 characters of output: WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/chromium/public/WebSettings.h Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebSettings.h.rej patching file WebKit/chromium/src/WebSettingsImpl.cpp Hunk #1 succeeded at 279 with fuzz 1 (offset 5 lines). patching file WebKit/chromium/src/WebSettingsImpl.h Hunk #1 FAILED at 86. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebSettingsImpl.h.rej Full output: http://webkit-commit-queue.appspot.com/results/2600095
James Robinson
Comment 5 2010-05-30 22:25:32 PDT
Looks like this collided with http://trac.webkit.org/changeset/60411. I guess this is why people avoid append-at-the-end :). Will resolve and land manually.
James Robinson
Comment 6 2010-05-31 23:21:33 PDT
Committed r60464: <http://trac.webkit.org/changeset/60464>
Note You need to log in before you can comment on or make changes to this bug.