Bug 39896

Summary:

[V8] DB V8 bindings should not pass empty handles to V8 code

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ericu, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	abarth: review-, dumi: commit-queue-
patch	dumi: commit-queue-
patch	abarth: review+, dumi: commit-queue-

Dumitru Daniliuc

Reported 2010-05-28 12:30:34 PDT

Currently, none of the DB V8 bindings check if any of the arguments passed to invokeCallback() is empty. According to Mats Ager, toV8() can sometimes return empty handles, and passing them to invokeCallback() would cause v8 to crash. We should fix that.

Attachments
patch (4.23 KB, patch) 2010-05-28 13:36 PDT, Dumitru Daniliuc	abarth: review- dumi: commit-queue-	Details Formatted Diff Diff
patch (5.16 KB, patch) 2010-06-04 18:42 PDT, Dumitru Daniliuc	dumi: commit-queue-	Details Formatted Diff Diff
patch (5.49 KB, patch) 2010-06-04 19:16 PDT, Dumitru Daniliuc	abarth: review+ dumi: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-05-28 13:36:59 PDT

Created attachment 57370 [details] patch

Adam Barth

Comment 2 2010-05-28 14:05:07 PDT

Comment on attachment 57370 [details] patch Test?

Dumitru Daniliuc

Comment 3 2010-06-04 18:42:15 PDT

Created attachment 57937 [details] patch

Adam Barth

Comment 4 2010-06-04 18:43:53 PDT

Comment on attachment 57937 [details] patch Hum... We should add a lot more information to the ChangeLog about why we're doing this in case someone is curious about this rather strange patch.

Dumitru Daniliuc

Comment 5 2010-06-04 19:16:13 PDT

Created attachment 57946 [details] patch

Adam Barth

Comment 6 2010-06-04 19:17:27 PDT

Comment on attachment 57946 [details] patch ok, hopefully this will help you gather more useful information

Dumitru Daniliuc

Comment 7 2010-06-05 13:19:41 PDT

Landed as r60754.

Dumitru Daniliuc

Comment 8 2010-06-05 13:36:26 PDT

r60755 fixed a typo that caused a build failure.

WebKit Review Bot

Comment 9 2010-06-05 13:40:00 PDT

http://trac.webkit.org/changeset/60754 might have broken Chromium Mac Release

Note You need to log in before you can comment on or make changes to this bug.