Bug 39865 – [EFL] Set web database path

• Component: New Bugs
• Status: RESOLVED FIXED

[Lucas De Marchi]

[EFL] Set web database path

[Lucas De Marchi]

Created attachment 57301 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 57301 [details]
Patch

WebKit/efl/ewk/ewk_main.cpp:119
 +      ewk_settings_web_database_path_set(getenv("HOME"));
Do you really want to store that directly in home?

[Gustavo Sverzut Barbieri]

(In reply to comment #2)
> (From update of attachment 57301 [details])
> WebKit/efl/ewk/ewk_main.cpp:119
>  +      ewk_settings_web_database_path_set(getenv("HOME"));
> Do you really want to store that directly in home?

Kenneth is right, saving it under ~/.cache/ewebkit is better as some systems may provide cleanup there.

Real apps should store that in ${XDG_CONFIG_HOME:-$HOME/.config}/$APP so it is not cleaned. But then we need the $APP to be correct and I'm not sure going with $APP = $ARGV[0] is a good choice, so have a sane default and have the apps to override it.

[WebKit Commit Bot]

Comment on attachment 57301 [details]
Patch

Clearing flags on attachment: 57301

Committed r60363: <http://trac.webkit.org/changeset/60363>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.