Bug 39849

Summary: We don't test the async DB success callback in an isolated world.
Product: WebKit Reporter: Eric U. <ericu>
Component: Tools / TestsAssignee: Eric U. <ericu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dumi, eric, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Eric U.
Reported 2010-05-27 10:58:32 PDT
We've got a test for the error callback, but not the success callback. They go through slightly different code, so we should test both.
Attachments
Patch (3.08 KB, patch)
2010-05-27 13:00 PDT, Eric U. 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric U.
Comment 1 2010-05-27 13:00:25 PDT
Created attachment 57268 [details] Patch
Dumitru Daniliuc
Comment 2 2010-05-27 13:39:57 PDT
LGTM.
Dmitry Titov
Comment 3 2010-05-28 12:50:39 PDT
Comment on attachment 57268 [details] Patch r=me
WebKit Commit Bot
Comment 4 2010-05-28 20:33:53 PDT
Comment on attachment 57268 [details] Patch Clearing flags on attachment: 57268 Committed r60386: <http://trac.webkit.org/changeset/60386>
WebKit Commit Bot
Comment 5 2010-05-28 20:33:58 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-05-28 20:58:13 PDT
http://trac.webkit.org/changeset/60386 might have broken Qt Linux Release
Eric Seidel (no email)
Comment 7 2010-05-28 22:12:33 PDT
Looks like it needs a skip on qt. On my phone or I'd be happy to.
Csaba Osztrogonác
Comment 8 2010-05-28 22:33:43 PDT
(In reply to comment #7) > Looks like it needs a skip on qt. On my phone or I'd be happy to Absolutely true, I did it: http://trac.webkit.org/changeset/60388 Thx for the notification.
Note You need to log in before you can comment on or make changes to this bug.