Bug 39849 - We don't test the async DB success callback in an isolated world.
Summary: We don't test the async DB success callback in an isolated world.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric U.
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 10:58 PDT by Eric U.
Modified: 2010-05-28 22:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2010-05-27 13:00 PDT, Eric U. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric U. 2010-05-27 10:58:32 PDT 
We've got a test for the error callback, but not the success callback.
They go through slightly different code, so we should test both.
Comment 1 Eric U. 2010-05-27 13:00:25 PDT 
Created attachment 57268 [details]
Patch
Comment 2 Dumitru Daniliuc 2010-05-27 13:39:57 PDT 
LGTM.
Comment 3 Dmitry Titov 2010-05-28 12:50:39 PDT 
Comment on attachment 57268 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2010-05-28 20:33:53 PDT 
Comment on attachment 57268 [details]
Patch

Clearing flags on attachment: 57268

Committed r60386: <http://trac.webkit.org/changeset/60386>
Comment 5 WebKit Commit Bot 2010-05-28 20:33:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-05-28 20:58:13 PDT 
http://trac.webkit.org/changeset/60386 might have broken Qt Linux Release
Comment 7 Eric Seidel (no email) 2010-05-28 22:12:33 PDT 
Looks like it needs a skip on qt.  On my phone or I'd be happy to.
Comment 8 Csaba Osztrogonác 2010-05-28 22:33:43 PDT 
(In reply to comment #7)
> Looks like it needs a skip on qt.  On my phone or I'd be happy to
Absolutely true, I did it: http://trac.webkit.org/changeset/60388
Thx for the notification.