| Summary: | webkit-gtk 1.2.1 won't build on 10.4 Tiger : FastMalloc.cpp:1702: error | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Le Lay <elelay> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Blocker | CC: | berto | ||||
| Priority: | P1 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac (PowerPC) | ||||||
| OS: | OS X 10.4 | ||||||
| Attachments: |
|
||||||
This is already fixed http://trac.webkit.org/changeset/58355 |
Created attachment 57256 [details] patch fixing the compilation error I end up with a compilation error in webkit-1.2.1/JavaScriptCore/wtf/FastMalloc.cpp : {{{ CXX JavaScriptCore/wtf/libJavaScriptCore_la-FastMalloc.lo JavaScriptCore/wtf/FastMalloc.cpp: In member function 'void WTF::TCMalloc_PageHeap::Carve(WTF::Span*, WTF::Length, bool)': JavaScriptCore/wtf/FastMalloc.cpp:1702: error: 'free_committed_pages_' was not declared in this scope make[1]: *** [JavaScriptCore/wtf/libJavaScriptCore_la-FastMalloc.lo] Error 1 make: *** [all] Error 2 }}} It seems that not all usage of free_committed_pages_ are guarded by USE_BACKGROUND_THREAD_TO_SCAVENGE_MEMORY, so I removed the guards around its definition.