Bug 39838

Summary: [v8] Web Inspector: notify ScriptDebugListener when execution is resumed
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Yury Semikhatsky
Reported 2010-05-27 07:44:45 PDT
ScriptDebugListener::didContinue should be invoked when script execution is resumed.
Attachments
Patch (1.23 KB, patch)
2010-05-27 08:02 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2010-05-27 09:59 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-05-27 08:02:13 PDT
Created attachment 57244 [details] Patch
Pavel Feldman
Comment 2 2010-05-27 08:07:31 PDT
Comment on attachment 57244 [details] Patch WebCore/bindings/v8/ScriptDebugServer.cpp:307 + Consider removing this blank line :)
Yury Semikhatsky
Comment 3 2010-05-27 08:16:35 PDT
Comment on attachment 57244 [details] Patch Clearing flags on attachment: 57244 Committed r60302: <http://trac.webkit.org/changeset/60302>
Yury Semikhatsky
Comment 4 2010-05-27 08:16:45 PDT
All reviewed patches have been landed. Closing bug.
Yury Semikhatsky
Comment 5 2010-05-27 09:56:16 PDT
We should check that the listener was not removed while messages were dispatched in the nested loop.
Yury Semikhatsky
Comment 6 2010-05-27 09:59:19 PDT
Created attachment 57253 [details] Patch
Joseph Pecoraro
Comment 7 2010-05-27 10:12:01 PDT
That compiles? I've never been a fan of shadowing variables by reusing a variable name in an inner block. I realize this is v8 only, but you might want to consider changing the new variable name from "listener" to something else.
Yury Semikhatsky
Comment 8 2010-05-27 10:14:16 PDT
Committed r60309(In reply to comment #7) > That compiles? I've never been a fan of shadowing variables by reusing a variable name in an inner block. I realize this is v8 only, but you might want to consider changing the new variable name from "listener" to something else. I've already committed the patch as r60309. Will address your comment in one of the next patches.
Note You need to log in before you can comment on or make changes to this bug.