Bug 39838

Summary: [v8] Web Inspector: notify ScriptDebugListener when execution is resumed
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Yury Semikhatsky 2010-05-27 07:44:45 PDT 
ScriptDebugListener::didContinue should be invoked when script execution is resumed.
Comment 1 Yury Semikhatsky 2010-05-27 08:02:13 PDT 
Created attachment 57244 [details]
Patch
Comment 2 Pavel Feldman 2010-05-27 08:07:31 PDT 
Comment on attachment 57244 [details]
Patch

WebCore/bindings/v8/ScriptDebugServer.cpp:307
 +  
Consider removing this blank line :)
Comment 3 Yury Semikhatsky 2010-05-27 08:16:35 PDT 
Comment on attachment 57244 [details]
Patch

Clearing flags on attachment: 57244

Committed r60302: <http://trac.webkit.org/changeset/60302>
Comment 4 Yury Semikhatsky 2010-05-27 08:16:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Yury Semikhatsky 2010-05-27 09:56:16 PDT 
We should check that the listener was not removed while messages were dispatched in the nested loop.
Comment 6 Yury Semikhatsky 2010-05-27 09:59:19 PDT 
Created attachment 57253 [details]
Patch
Comment 7 Joseph Pecoraro 2010-05-27 10:12:01 PDT 
That compiles? I've never been a fan of shadowing variables by reusing a variable name in an inner block. I realize this is v8 only, but you might want to consider changing the new variable name from "listener" to something else.
Comment 8 Yury Semikhatsky 2010-05-27 10:14:16 PDT 
Committed r60309(In reply to comment #7)
> That compiles? I've never been a fan of shadowing variables by reusing a variable name in an inner block. I realize this is v8 only, but you might want to consider changing the new variable name from "listener" to something else.

I've already committed the patch as r60309. Will address your comment in one of the next patches.