Bug 39829

Summary: [GTK] Implement ThreadSpecific with glib
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, gustavo, joybro201, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch oliver: review+, oliver: commit-queue+

Kwang Yul Seo
Reported 2010-05-27 04:53:50 PDT
Implement ThreadSpecific with glib's GStaticPrivate. This patch makes it possible to build GTK port without pthread.
Attachments
Patch (3.85 KB, patch)
2010-05-27 04:56 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (4.04 KB, patch)
2010-05-27 07:17 PDT, Kwang Yul Seo 		oliver: review+
oliver: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-05-27 04:56:58 PDT
Created attachment 57224 [details] Patch
WebKit Review Bot
Comment 2 2010-05-27 06:54:02 PDT
Attachment 57224 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/2526083
Kwang Yul Seo
Comment 3 2010-05-27 07:17:34 PDT
Created attachment 57240 [details] Patch Fix the build error.
Eric Seidel (no email)
Comment 4 2010-06-12 20:46:44 PDT
Comment on attachment 57240 [details] Patch Cry. We need to split this out into some sort of ThreadSpecificGtk.h some day. Otherwise modifications to this file cause full rebuilds of every port. :(
Kwang Yul Seo
Comment 5 2010-06-14 11:05:22 PDT
(In reply to comment #4) > (From update of attachment 57240 [details]) > Cry. We need to split this out into some sort of ThreadSpecificGtk.h some day. Otherwise modifications to this file cause full rebuilds of every port. :( Okay. This is the same problem as OwnPtrCommon.h. I will file a bug for this once this patch is reviewed.
Eric Seidel (no email)
Comment 6 2010-06-23 15:29:01 PDT
The commit-queue had some hiccups, but this was finally landed as http://trac.webkit.org/changeset/61712
WebKit Review Bot
Comment 7 2010-06-23 16:22:34 PDT
http://trac.webkit.org/changeset/61712 might have broken GTK Linux 64-bit Debug
Kwang Yul Seo
Comment 8 2010-06-23 23:50:58 PDT
(In reply to comment #7) > http://trac.webkit.org/changeset/61712 might have broken GTK Linux 64-bit Debug Where can I check the build logs for GTK Linux 64-bit Debug?
Eric Seidel (no email)
Comment 9 2010-06-24 00:47:20 PDT
build.webkit.org has all the bots and logs. The EWS logs are linked from the EWS bubbles.
Note You need to log in before you can comment on or make changes to this bug.