Bug 39821

Summary:

[EFL] Add Context Menu support

Product:

WebKit

Reporter:

Lucas De Marchi <lucas.de.marchi>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barbieri, commit-queue, kenneth

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

39629

Bug Blocks:

Attachments:

Description	Flags
implement context menu	none
Patch	none
Patch	none
Patch	none

Lucas De Marchi

Reported 2010-05-27 02:02:17 PDT

Add context menu support in EFL port.

Attachments
implement context menu (17.59 KB, patch) 2010-05-27 02:08 PDT, Lucas De Marchi	no flags	Details Formatted Diff Diff
Patch (33.96 KB, patch) 2010-05-28 03:53 PDT, Lucas De Marchi	no flags	Details Formatted Diff Diff
Patch (35.68 KB, patch) 2010-05-28 18:42 PDT, Lucas De Marchi	no flags	Details Formatted Diff Diff
Patch (35.61 KB, patch) 2010-05-31 14:53 PDT, Lucas De Marchi	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Lucas De Marchi

Comment 1 2010-05-27 02:08:37 PDT

Created attachment 57211 [details] implement context menu This is the patch that must be applied after its dependency lands. Please, review #39629.

Lucas De Marchi

Comment 2 2010-05-28 03:53:27 PDT

Created attachment 57314 [details] Patch

Lucas De Marchi

Comment 3 2010-05-28 03:55:16 PDT

Updated to latest changes and include files in build system.

Lucas De Marchi

Comment 4 2010-05-28 10:29:52 PDT

Comment on attachment 57314 [details] Patch Clearing flags to update new version and force style check

Lucas De Marchi

Comment 5 2010-05-28 18:42:23 PDT

Created attachment 57401 [details] Patch

Kenneth Rohde Christiansen

Comment 6 2010-05-31 08:39:38 PDT

Comment on attachment 57401 [details] Patch Please take these comments into account WebCore/platform/efl/ContextMenuEfl.cpp:36 + static_cast<ContextMenuClientEfl*>(controller()->client()); Put this on one line please WebCore/platform/efl/ContextMenuEfl.cpp:45 + static_cast<ContextMenuClientEfl*>(controller()->client()); here as well WebCore/platform/efl/ContextMenuEfl.cpp:75 + // Ref counting remains the same, just pass it and remove our ref, so it ref count remainds the same, that is what you want to say right? WebCore/platform/efl/ContextMenuItemEfl.cpp:40 + // it's inside WebKit that this initialization is done, as WebCore doesn't Comments start with capital letter and ends with a dot/punctuation mark. WebKit/efl/WebCoreSupport/ContextMenuClientEfl.h:53 + PlatformMenuDescription newPlatformDescription(ContextMenu*); what about createPlatformDescription ? WebKit/efl/ewk/ewk_contextmenu.cpp:114 + // don't care about title and submenu as they're not used after this point Capital + dot please WebKit/efl/ewk/ewk_contextmenu.h:68 + // these are new tags! not a part of api!!!! How so? You should probably make a better comment

Lucas De Marchi

Comment 7 2010-05-31 14:53:35 PDT

Created attachment 57496 [details] Patch

WebKit Commit Bot

Comment 8 2010-05-31 15:58:56 PDT

Comment on attachment 57496 [details] Patch Clearing flags on attachment: 57496 Committed r60454: <http://trac.webkit.org/changeset/60454>

WebKit Commit Bot

Comment 9 2010-05-31 15:59:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.