Summary: | Update the block of characters that need to go to complex script path | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jungshik Shin <jshin> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Jungshik Shin <jshin> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | ap, mitz, simon.fraser, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
URL: | http://ja.wikipedia.org/wiki/JIS_X_0213%E9%9D%9E%E6%BC%A2%E5%AD%97%E4%B8%80 %E8%A6%A7 | ||||||||||||||
Attachments: |
|
Description
Jungshik Shin
2010-05-26 17:20:50 PDT
Created attachment 57282 [details]
test file
Lines 2 - 6 contain sequences of IPA tone letters that have to be ligated instead of being rendered separately.
Created attachment 61297 [details]
patch (layout test without expected results, change log)
Just to stow away my patch and layout test. Not for review, yet.
Created attachment 90148 [details]
updated patch (to Unicode 6.0)
Updated the patch to list all the 'complex script blocks' in Unicode 6.0. I'll generate the layout test results tomorrow and update the patch again. (at the moment, remote connections to Win/Mac do not work well).
Created attachment 90277 [details]
patch with layout test and result
Attachment 90277 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 90278 [details]
updated patch with style nits fixed
Comment on attachment 90278 [details]
updated patch with style nits fixed
rs=me
This test is failing on Mac SnowLeopard for me: "FAIL: The following strings are rendered differently depending on what text-rendering is set to : ˥˧˥" |