Summary: | Public GIF decoder fails to mark some images as "done" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||
Component: | Images | Assignee: | Peter Kasting <pkasting> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, hyatt | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
URL: | http://threeframes.net/ | ||||||
Attachments: |
|
Description
Peter Kasting
2010-05-26 14:55:49 PDT
Created attachment 57165 [details]
patch v1
This patch fixes both places that failed to use GETN() to change state: one by using the macro, and the other by eliminating it entirely. (WebKit uses this code differently than Mozilla did, and marking corrupt GIFs as "failed" won't prevent their display.)
Comment on attachment 57165 [details]
patch v1
I have no idea what this does, but I believe you. It's too bad we don't have more than one image expert.
Maybe Hyatt has some idea who might know this code better? (In reply to comment #3) > Maybe Hyatt has some idea who might know this code better? Sadly, I think hyatt and I are the only people to have worked on this, and it was years ago for him. I probably ought to just gut GIFImageReader.cpp someday and rewrite it from scratch. It's been a never-ending source of problems. |