Bug 39783

Summary: moveChild function cleanup in RenderBlock
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 39788    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
hyatt: review-
Patch sam: review+

Dave Hyatt
Reported 2010-05-26 14:11:14 PDT
Clean up functions and reduce the # of arguments they need.
Attachments
Patch (10.72 KB, patch)
2010-05-26 14:13 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (10.71 KB, patch)
2010-05-26 14:16 PDT, Dave Hyatt 		hyatt: review-
DetailsFormatted DiffDiff
Patch (12.75 KB, patch)
2010-05-26 16:42 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-05-26 14:13:44 PDT
Created attachment 57133 [details] Patch
Dave Hyatt
Comment 2 2010-05-26 14:16:17 PDT
Created attachment 57134 [details] Patch
Dave Hyatt
Comment 3 2010-05-26 14:26:04 PDT
Fixed in r60251.
WebKit Review Bot
Comment 4 2010-05-26 14:50:11 PDT
http://trac.webkit.org/changeset/60251 might have broken Qt Linux Release
Dave Hyatt
Comment 5 2010-05-26 15:07:00 PDT
*** Bug 39785 has been marked as a duplicate of this bug. ***
Dave Hyatt
Comment 6 2010-05-26 15:07:27 PDT
Reopening, had to roll out.
Dave Hyatt
Comment 7 2010-05-26 15:08:01 PDT
Comment on attachment 57134 [details] Patch Not good.
Dave Hyatt
Comment 8 2010-05-26 16:42:20 PDT
Created attachment 57179 [details] Patch
Dave Hyatt
Comment 9 2010-05-26 17:41:06 PDT
Fixed in r60262.
WebKit Review Bot
Comment 10 2010-05-26 17:48:02 PDT
http://trac.webkit.org/changeset/60262 might have broken Qt Linux ARMv5 Release
Eric Seidel (no email)
Comment 11 2010-05-26 18:35:25 PDT
This broke every builder.
Adam Barth
Comment 12 2010-05-26 18:37:15 PDT
Reverted r60262 for reason: Broke every build and is blocking me from working. :( Committed r60264: <http://trac.webkit.org/changeset/60264>
Dave Hyatt
Comment 13 2010-05-27 01:31:23 PDT
Landed in r60282.
Note You need to log in before you can comment on or make changes to this bug.