Bug 39783 - moveChild function cleanup in RenderBlock
Summary: moveChild function cleanup in RenderBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
: 39785 (view as bug list)
Depends on: 39788
Blocks:
  Show dependency tree / graph
 
Reported: 2010-05-26 14:11 PDT by Dave Hyatt
Modified: 2010-05-27 01:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.72 KB, patch)
2010-05-26 14:13 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (10.71 KB, patch)
2010-05-26 14:16 PDT, Dave Hyatt 		hyatt: review-
Details | Formatted Diff | Diff
Patch (12.75 KB, patch)
2010-05-26 16:42 PDT, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-05-26 14:11:14 PDT 
Clean up functions and reduce the # of arguments they need.
Comment 1 Dave Hyatt 2010-05-26 14:13:44 PDT 
Created attachment 57133 [details]
Patch
Comment 2 Dave Hyatt 2010-05-26 14:16:17 PDT 
Created attachment 57134 [details]
Patch
Comment 3 Dave Hyatt 2010-05-26 14:26:04 PDT 
Fixed in r60251.
Comment 4 WebKit Review Bot 2010-05-26 14:50:11 PDT 
http://trac.webkit.org/changeset/60251 might have broken Qt Linux Release
Comment 5 Dave Hyatt 2010-05-26 15:07:00 PDT 
*** Bug 39785 has been marked as a duplicate of this bug. ***
Comment 6 Dave Hyatt 2010-05-26 15:07:27 PDT 
Reopening, had to roll out.
Comment 7 Dave Hyatt 2010-05-26 15:08:01 PDT 
Comment on attachment 57134 [details]
Patch

Not good.
Comment 8 Dave Hyatt 2010-05-26 16:42:20 PDT 
Created attachment 57179 [details]
Patch
Comment 9 Dave Hyatt 2010-05-26 17:41:06 PDT 
Fixed in r60262.
Comment 10 WebKit Review Bot 2010-05-26 17:48:02 PDT 
http://trac.webkit.org/changeset/60262 might have broken Qt Linux ARMv5 Release
Comment 11 Eric Seidel (no email) 2010-05-26 18:35:25 PDT 
This broke every builder.
Comment 12 Adam Barth 2010-05-26 18:37:15 PDT 
Reverted r60262 for reason:

Broke every build and is blocking me from working.  :(

Committed r60264: <http://trac.webkit.org/changeset/60264>
Comment 13 Dave Hyatt 2010-05-27 01:31:23 PDT 
Landed in r60282.