Summary: | [Qt] CookieJarQt.cpp has coding-style errors | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Bakken <agbakken> | ||||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, levin, peojala11 | ||||||||
Priority: | P5 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Anders Bakken
2010-05-26 13:37:38 PDT
Created attachment 57159 [details]
Patch that fixes the coding style issues
Qt, QtTriaged Comment on attachment 57159 [details] Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. Created attachment 57954 [details]
Patch
Comment on attachment 57954 [details]
Patch
Seems silly to not just make this a one-line function call now:
QNetworkCookieJar* jar = cookieJar(document);
125 return (jar != 0);
125 return jar;
You could use !!cookieJar(document)
to make it clear that your'e returnign a bool if you like.
Comment on attachment 57954 [details]
Patch
Please consider Eric's comment.
Anders, what is the status of this? Created attachment 78255 [details]
Patch
Comment on attachment 78255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78255&action=review > WebCore/platform/qt/CookieJarQt.cpp:117 > - return networkAccessManager(document); > + return !!networkAccessManager(document); It this in the coding style guide? Comment on attachment 78255 [details]
Patch
Oh, let's answer Kenneth's question first.
(In reply to comment #9) > > WebCore/platform/qt/CookieJarQt.cpp:117 > > - return networkAccessManager(document); > > + return !!networkAccessManager(document); > > It this in the coding style guide? No, it was to address Eric Seidel comment (comment 5). Comment on attachment 78255 [details] Patch Clearing flags on attachment: 78255 Committed r75334: <http://trac.webkit.org/changeset/75334> All reviewed patches have been landed. Closing bug. |