Bug 39756

Summary: Must not cast between CFNumberRef and CFBooleanRef
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Severity: Normal Keywords: InRadar, PlatformOnly
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Description Flags
proposed patch mitz: review+

Description Eric Carlson 2010-05-26 11:59:00 PDT
CoreFoundation toll-free bridging assumes that if the value passed to CFBooleanGetValue is not a CFBooleanRef, it is some objc value and calls objc_msgSend to get the -boolValue. 

QTMovieVisualContext::getCGImageOptions adds a CFNumberRef with a value of 1 to a dictionary for a key that is expected to be a CFBoolean, it should add kCFBooleanTrue instead.
Comment 1 Eric Carlson 2010-05-26 11:59:31 PDT
Comment 2 Eric Carlson 2010-05-26 12:02:26 PDT
Created attachment 57124 [details]
proposed patch
Comment 3 Eric Carlson 2010-05-26 12:08:18 PDT