Bug 39756

Summary: Must not cast between CFNumberRef and CFBooleanRef
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar, PlatformOnly
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
proposed patch mitz: review+

Eric Carlson
Reported 2010-05-26 11:59:00 PDT
CoreFoundation toll-free bridging assumes that if the value passed to CFBooleanGetValue is not a CFBooleanRef, it is some objc value and calls objc_msgSend to get the -boolValue. QTMovieVisualContext::getCGImageOptions adds a CFNumberRef with a value of 1 to a dictionary for a key that is expected to be a CFBoolean, it should add kCFBooleanTrue instead.
Attachments
proposed patch (1.50 KB, patch)
2010-05-26 12:02 PDT, Eric Carlson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2010-05-26 11:59:31 PDT
<rdar://problem/8030739>
Eric Carlson
Comment 2 2010-05-26 12:02:26 PDT
Created attachment 57124 [details] proposed patch
Eric Carlson
Comment 3 2010-05-26 12:08:18 PDT
http://trac.webkit.org/changeset/60245
Note You need to log in before you can comment on or make changes to this bug.