| Summary: | Teach the HTML5 parser how to handle external scripts | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, tonyg, webkit-ews, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 39259 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Seidel (no email)
2010-05-26 02:47:34 PDT
I have a work in progress I'll upload. It causes a bunch of test regressions and is not nearly ready for review yet (but it does handle simple <script src=""> tags!). Created attachment 57084 [details]
very rough work in progress which makes external scripts work
Created attachment 57180 [details]
slightly better work in progress
Comment on attachment 57180 [details]
slightly better work in progress
Didn't mean to mark this for review, sorry.
Created attachment 57196 [details]
for adam to look at while I clean it up a bit yet
Created attachment 57199 [details]
Ready for review
Attachment 57199 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2497061 Comment on attachment 57199 [details]
Ready for review
Thanks for working on this patch. I know it was painful, but this looks like a good patch to start iterating from. Please address the verbal comments before landing.
WebCore/html/HTML5TreeBuilder.cpp:120
+ m_isPaused = false;
I'm not 100% sold on this model, but we'll see how it pans out.
Committed r60275: <http://trac.webkit.org/changeset/60275> Attachment 57199 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2514084 |