Bug 39716

Summary:

Teach the HTML5 parser how to handle external scripts

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, tonyg, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

39259

Attachments:

Description	Flags
very rough work in progress which makes external scripts work	none
slightly better work in progress	none
for adam to look at while I clean it up a bit yet	none
Ready for review	abarth: review+

Eric Seidel (no email)

Reported 2010-05-26 02:47:34 PDT

Teach the HTML5 parser how to handle external scripts

Attachments
very rough work in progress which makes external scripts work (28.18 KB, patch) 2010-05-26 02:50 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
slightly better work in progress (31.92 KB, patch) 2010-05-26 17:45 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
for adam to look at while I clean it up a bit yet (32.31 KB, patch) 2010-05-26 22:56 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Ready for review (38.40 KB, patch) 2010-05-26 23:38 PDT, Eric Seidel (no email)	abarth: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-05-26 02:48:34 PDT

I have a work in progress I'll upload. It causes a bunch of test regressions and is not nearly ready for review yet (but it does handle simple <script src=""> tags!).

Eric Seidel (no email)

Comment 2 2010-05-26 02:50:00 PDT

Created attachment 57084 [details] very rough work in progress which makes external scripts work

Eric Seidel (no email)

Comment 3 2010-05-26 17:45:02 PDT

Created attachment 57180 [details] slightly better work in progress

Eric Seidel (no email)

Comment 4 2010-05-26 17:45:43 PDT

Comment on attachment 57180 [details] slightly better work in progress Didn't mean to mark this for review, sorry.

Eric Seidel (no email)

Comment 5 2010-05-26 22:56:39 PDT

Created attachment 57196 [details] for adam to look at while I clean it up a bit yet

Eric Seidel (no email)

Comment 6 2010-05-26 23:38:30 PDT

Created attachment 57199 [details] Ready for review

Early Warning System Bot

Comment 7 2010-05-26 23:52:55 PDT

Attachment 57199 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2497061

Adam Barth

Comment 8 2010-05-26 23:59:18 PDT

Comment on attachment 57199 [details] Ready for review Thanks for working on this patch. I know it was painful, but this looks like a good patch to start iterating from. Please address the verbal comments before landing. WebCore/html/HTML5TreeBuilder.cpp:120 + m_isPaused = false; I'm not 100% sold on this model, but we'll see how it pans out.

Eric Seidel (no email)

Comment 9 2010-05-27 00:14:34 PDT

Committed r60275: <http://trac.webkit.org/changeset/60275>

WebKit Review Bot

Comment 10 2010-05-27 00:41:51 PDT

Attachment 57199 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2514084

Note You need to log in before you can comment on or make changes to this bug.