Summary: | Clean up MimeClassInfo and PluginInfo | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, darin, dglazkov, eric, jparent, mrobinson, ossy, rolandsteiner, tony, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Other | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Bug Depends on: | 39819 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Anders Carlsson
2010-05-25 17:09:33 PDT
Created attachment 57055 [details]
Patch
Attachment 57055 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2457005 Created attachment 57110 [details]
Patch
The new patch should fix the Chromium build. Attachment 57110 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2529033 Created attachment 57120 [details]
Patch
Attachment 57120 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2500036 Created attachment 57129 [details]
Patch
Comment on attachment 57129 [details] Patch > PluginData::~PluginData() > { > - deleteAllValues(m_plugins); > - deleteAllValues(m_mimes); > } It'd be nice to just let the compiler generate this and not define it explicitly at all. (In reply to comment #9) > (From update of attachment 57129 [details]) > > PluginData::~PluginData() > > { > > - deleteAllValues(m_plugins); > > - deleteAllValues(m_mimes); > > } > > It'd be nice to just let the compiler generate this and not define it explicitly at all. The destructor? Sure! Committed r60258: <http://trac.webkit.org/changeset/60258> http://trac.webkit.org/changeset/60258 might have broken GTK Linux 32-bit Release and Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/60257 http://trac.webkit.org/changeset/60258 This looks to have introduced a crash in fast/dom/prototype-inheritance-2.html. I see the crash on the following bots: * Chromium (linux, win, mac) * Leopard Intel Debug (Tests) * Snow Leopard Intel Leaks Is there a URL for the backtrace from the crash? I think that the crash was caused by another change - looks like Geoff fixed it in http://trac.webkit.org/changeset/60261 Here is the Chromium linux bot stack: StackTrace::StackTrace() [0x80eeacf] base::(anonymous namespace)::StackDumpSignalHandler() [0x80de9da] 0x4001c420 WebCore::collectionIndexedPropertyEnumerator<>() [0x89648a8] v8::internal::GetKeysForIndexedInterceptor() [0x81ba92e] Geoff's change was fixing a different crash. Looks like there may be new failures on Qt after this change? http://build.webkit.org/results/Qt%20Linux%20Release/r60258%20(12428)/results.html (In reply to comment #17) > Looks like there may be new failures on Qt after this change? > http://build.webkit.org/results/Qt%20Linux%20Release/r60258%20(12428)/results.html It seems this patch broke tests. I try to roll-out it locally now to confirm it. The crashing of fast/dom/prototype-inheritance-2.html also occurred during my WebKit gardening. I submitted and committed a quick fix in WebKit r60276. See https://bugs.webkit.org/show_bug.cgi?id=39811 |