Bug 39684

Summary:

Remove obsolete code from WebKit/chromium/src/FrameLoaderClientImpl.cpp

Product:

WebKit

Reporter:

Brett Wilson (Google) <brettw>

Component:

WebKit API

Assignee:

Brett Wilson (Google) <brettw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thakis

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Other

Attachments:

Description	Flags
Patch	fishd: review+, fishd: commit-queue-
New patch	none

Description Brett Wilson (Google) 2010-05-25 12:58:19 PDT

The #if !OS(WINDOWS) block in FrameLoaderClientImpl.::createPlugin appears to no longer be necessary and is preventing some things from working.

Comment 1 Brett Wilson (Google) 2010-05-25 13:01:43 PDT

Created attachment 57038 [details]
Patch

Comment 2 Darin Fisher (:fishd, Google) 2010-05-25 13:03:23 PDT

Comment on attachment 57038 [details]
Patch

> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 8593698..5fffb0d 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,14 @@
> +2010-05-25  Brett Wilson  <brettw@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Remove obsolete code for Mac & Windows plugin creation in the Chromium
> +        port. This non-Windows code was to prevent a crash which we no longer
> +        seem to have, and it is preventing other types of plugins from working.
> +

Add a bug reference here.

R=me

Comment 3 Brett Wilson (Google) 2010-05-25 13:04:46 PDT

Created attachment 57039 [details]
New patch

Comment 4 Brett Wilson (Google) 2010-05-25 13:14:11 PDT

Fixed in r60178

Comment 5 Nico Weber 2010-05-26 14:09:32 PDT

I wanted to remove that today too, to get the default plugin loading on mac and linux. Thanks :-)