Bug 39684

Summary: Remove obsolete code from WebKit/chromium/src/FrameLoaderClientImpl.cpp
Product: WebKit Reporter: Brett Wilson (Google) <brettw>
Component: WebKit APIAssignee: Brett Wilson (Google) <brettw>
Status: RESOLVED FIXED    
Severity: Normal CC: thakis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Patch
fishd: review+, fishd: commit-queue-
New patch none

Brett Wilson (Google)
Reported 2010-05-25 12:58:19 PDT
The #if !OS(WINDOWS) block in FrameLoaderClientImpl.::createPlugin appears to no longer be necessary and is preventing some things from working.
Attachments
Patch (1.78 KB, patch)
2010-05-25 13:01 PDT, Brett Wilson (Google) 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
New patch (1.84 KB, patch)
2010-05-25 13:04 PDT, Brett Wilson (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brett Wilson (Google)
Comment 1 2010-05-25 13:01:43 PDT
Created attachment 57038 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-05-25 13:03:23 PDT
Comment on attachment 57038 [details] Patch > diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog > index 8593698..5fffb0d 100644 > --- a/WebKit/chromium/ChangeLog > +++ b/WebKit/chromium/ChangeLog > @@ -1,3 +1,14 @@ > +2010-05-25 Brett Wilson <brettw@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Remove obsolete code for Mac & Windows plugin creation in the Chromium > + port. This non-Windows code was to prevent a crash which we no longer > + seem to have, and it is preventing other types of plugins from working. > + Add a bug reference here. R=me
Brett Wilson (Google)
Comment 3 2010-05-25 13:04:46 PDT
Created attachment 57039 [details] New patch
Brett Wilson (Google)
Comment 4 2010-05-25 13:14:11 PDT
Fixed in r60178
Nico Weber
Comment 5 2010-05-26 14:09:32 PDT
I wanted to remove that today too, to get the default plugin loading on mac and linux. Thanks :-)
Note You need to log in before you can comment on or make changes to this bug.