Bug 39679

Summary:

Add callbacks to ScriptController to allow notifications on named items additions and removals

Product:

WebKit

Reporter:

anton muhin <antonm>

Component:

WebCore Misc.

Assignee:

anton muhin <antonm>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
fixing const declaration for JSC	none

anton muhin

Reported 2010-05-25 10:54:06 PDT

Add callbacks to ScriptController to allow notifications on named items additions and removals

Attachments
Patch (4.88 KB, patch) 2010-05-25 10:59 PDT, anton muhin	no flags	Details Formatted Diff Diff
fixing const declaration for JSC (4.89 KB, patch) 2010-05-25 11:18 PDT, anton muhin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

anton muhin

Comment 1 2010-05-25 10:59:25 PDT

Created attachment 57030 [details] Patch

anton muhin

Comment 2 2010-05-25 11:00:42 PDT

This change allows to get rid of interceptor on HTMLDocument and thus provide faster access to properties.

Early Warning System Bot

Comment 3 2010-05-25 11:13:24 PDT

Attachment 57030 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2280585

anton muhin

Comment 4 2010-05-25 11:18:01 PDT

Created attachment 57033 [details] fixing const declaration for JSC

Adam Barth

Comment 5 2010-05-26 10:35:34 PDT

Comment on attachment 57033 [details] fixing const declaration for JSC WebCore/bindings/js/ScriptController.h:145 + void namedItemAdded(HTMLDocument*, const AtomicString&) { } I don't get it. These functions don't do anything.

anton muhin

Comment 6 2010-05-26 10:37:38 PDT

(In reply to comment #5) > (From update of attachment 57033 [details]) > WebCore/bindings/js/ScriptController.h:145 > + void namedItemAdded(HTMLDocument*, const AtomicString&) { } > I don't get it. These functions don't do anything. Yes. I've got a next patch, but I need V8 roll to enable it for V8 bindings. I tried to follow the protocol: 1) add generic interface; 2) add implementation for bindings. If you prefer to see two patches blended, I can do it in a second.

Adam Barth

Comment 7 2010-05-26 11:03:50 PDT

Comment on attachment 57033 [details] fixing const declaration for JSC Ok. It's a bit hard to see where this is going, but this patch seems harmless as written...

anton muhin

Comment 8 2010-05-26 11:05:56 PDT

Comment on attachment 57033 [details] fixing const declaration for JSC Thanks a lot, Adam, cq+'ing it. I'll cc you on next patch (when both WebKit and V8 get rolled into Chromium and stay for a day.)

WebKit Commit Bot

Comment 9 2010-05-27 05:01:11 PDT

Comment on attachment 57033 [details] fixing const declaration for JSC Clearing flags on attachment: 57033 Committed r60291: <http://trac.webkit.org/changeset/60291>

WebKit Commit Bot

Comment 10 2010-05-27 05:01:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.