Bug 39661

Summary:

Switch HTML parsing benchmark to use document.write instead of innerHTML

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2010-05-25 01:41:50 PDT

Switch HTML parsing benchmark to use document.write instead of innerHTML

Comment 1 Adam Barth 2010-05-25 01:43:15 PDT

Created attachment 56990 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-05-25 01:44:31 PDT

Comment on attachment 56990 [details]
Patch

OK.  How does the performance compare with the original benchmark?  Are we still spending a similar amount of time in the tokenizer/parser?  Please comment before landing.

Comment 3 Adam Barth 2010-05-25 01:59:58 PDT

Comment on attachment 56990 [details]
Patch

Yeah, it's still spending 10% of its time in parseTag (and 42% in functions below that).

Comment 4 WebKit Commit Bot 2010-05-25 05:55:27 PDT

Comment on attachment 56990 [details]
Patch

Clearing flags on attachment: 56990

Committed r60157: <http://trac.webkit.org/changeset/60157>

Comment 5 WebKit Commit Bot 2010-05-25 05:55:33 PDT

All reviewed patches have been landed.  Closing bug.