Bug 39655

Summary:

[v8] The 'prototype' property on generated Web IDL interfaces should be { DontDelete | ReadOnly }.

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

WebKit Misc.

Assignee:

Dominic Cooney <dominicc>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ager, dglazkov, dominicc, kling, shinyak, vitalyr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Updates binding test expected results.	none

Tony Chang

Reported 2010-05-25 00:45:33 PDT

JSC changed behavior in http://trac.webkit.org/changeset/60119. This is causing the layout test fast/dom/prototype-property.html to fail.

Attachments
Patch (2.94 KB, patch) 2011-08-08 05:31 PDT, Dominic Cooney	no flags	Details Formatted Diff Diff
Updates binding test expected results. (6.96 KB, patch) 2011-08-08 16:44 PDT, Dominic Cooney	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2010-05-25 00:55:41 PDT

I'm going to mark the test as failing for now so I can roll WebKit DEPS.

Tony Chang

Comment 2 2010-05-26 00:00:56 PDT

vitalyr has been volunteered to look at this :)

Dominic Cooney

Comment 3 2011-06-16 04:07:43 PDT

For reference, the relevant part of the Web IDL spec is <http://dev.w3.org/2006/webapi/WebIDL/#interface-object> which says: The interface object must also have a property named prototype with attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false } whose value is an object called the interface prototype object.

Dominic Cooney

Comment 4 2011-06-16 06:42:47 PDT

I have filed V8 issue 1479 for the desired API changes on the V8 side. <http://code.google.com/p/v8/issues/detail?id=1479>

Dominic Cooney

Comment 5 2011-07-05 06:34:39 PDT

I believe there is another blocking bug on the V8 side; I have filed <http://code.google.com/p/v8/issues/detail?id=1539> for it.

Dominic Cooney

Comment 6 2011-08-08 05:31:35 PDT

Created attachment 103232 [details] Patch

Dominic Cooney

Comment 7 2011-08-08 16:44:17 PDT

Created attachment 103313 [details] Updates binding test expected results.

WebKit Review Bot

Comment 8 2011-08-09 21:52:05 PDT

Comment on attachment 103313 [details] Updates binding test expected results. Clearing flags on attachment: 103313 Committed r92747: <http://trac.webkit.org/changeset/92747>

WebKit Review Bot

Comment 9 2011-08-09 21:52:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.