Bug 39619

Summary:

Silence GCC warning

Product:

WebKit

Reporter:

Anders Bakken <agbakken>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch to silence GCC warning	none
Patch to silence GCC warning	darin: review-, darin: commit-queue-
Patch to silence GCC warning	none

Anders Bakken

Reported 2010-05-24 14:26:38 PDT

Created attachment 56926 [details] Patch to silence GCC warning GCC complains about these kinds of statements: if (foo || bar && barfood) foobar(); suggest parentheses around && within ||

Attachments
Patch to silence GCC warning (1.46 KB, patch) 2010-05-24 14:26 PDT, Anders Bakken	no flags	Details Formatted Diff Diff
Patch to silence GCC warning (1.47 KB, patch) 2010-05-24 14:52 PDT, Anders Bakken	darin: review- darin: commit-queue-	Details Formatted Diff Diff
Patch to silence GCC warning (1.46 KB, patch) 2010-05-24 16:21 PDT, Anders Bakken	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2010-05-24 14:27:20 PDT

Attachment 56926 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Bakken

Comment 2 2010-05-24 14:52:47 PDT

Created attachment 56931 [details] Patch to silence GCC warning

Darin Adler

Comment 3 2010-05-24 15:56:49 PDT

Comment on attachment 56931 [details] Patch to silence GCC warning > + GCC suggest parentheses aroundï¿½&&ï¿½withinï¿½|| Looks like you pasted some non-ASCII characters here. We can't land the ChangeLog like this, so review-. Change is otherwise fine.

Anders Bakken

Comment 4 2010-05-24 16:21:42 PDT

Created attachment 56941 [details] Patch to silence GCC warning

WebKit Commit Bot

Comment 5 2010-05-25 03:07:52 PDT

Comment on attachment 56941 [details] Patch to silence GCC warning Clearing flags on attachment: 56941 Committed r60152: <http://trac.webkit.org/changeset/60152>

WebKit Commit Bot

Comment 6 2010-05-25 03:07:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.