Bug 39615

Summary:

Implement basic column-span support

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Minor tweak - drop toRenderBlock casts when asking isAnonymousColumnSpanBlock, since I made it a RenderObject method	mitz: review+

Dave Hyatt

Reported 2010-05-24 13:43:09 PDT

Only if the column-span is an immediate child of the multicol block in this first step...

Attachments
Patch (1.89 MB, patch) 2010-05-24 14:11 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (1.89 MB, patch) 2010-05-24 14:38 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (1.89 MB, patch) 2010-05-24 20:24 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (1.89 MB, patch) 2010-05-25 03:15 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Minor tweak - drop toRenderBlock casts when asking isAnonymousColumnSpanBlock, since I made it a RenderObject method (1.89 MB, patch) 2010-05-25 14:06 PDT, Dave Hyatt	mitz: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2010-05-24 14:11:28 PDT

Created attachment 56924 [details] Patch

WebKit Review Bot

Comment 2 2010-05-24 14:13:42 PDT

Attachment 56924 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/RenderBlock.cpp:280: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebCore/rendering/RenderBlock.cpp:368: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 3 2010-05-24 14:38:21 PDT

Created attachment 56927 [details] Patch

Dave Hyatt

Comment 4 2010-05-24 20:24:14 PDT

Created attachment 56965 [details] Patch Address Dan's comments, clean up typos in changelog.

Dave Hyatt

Comment 5 2010-05-25 03:15:12 PDT

Created attachment 57001 [details] Patch

Dave Hyatt

Comment 6 2010-05-25 14:06:08 PDT

Created attachment 57044 [details] Minor tweak - drop toRenderBlock casts when asking isAnonymousColumnSpanBlock, since I made it a RenderObject method

mitz

Comment 7 2010-05-25 14:52:47 PDT

Comment on attachment 57044 [details] Minor tweak - drop toRenderBlock casts when asking isAnonymousColumnSpanBlock, since I made it a RenderObject method WebCore/rendering/RenderBlock.cpp:287 + RenderBlock* newBox = 0; You don’t need to initialize this to 0. Or you could initialize it with a ternary operator. WebCore/rendering/RenderBlock.cpp:311 + RenderBlock* newBox = 0; Ditto. Everything else is scary but fine. r=me

Dave Hyatt

Comment 8 2010-05-25 17:19:30 PDT

Landed in r60201.

Csaba Osztrogonác

Comment 9 2010-05-26 01:53:40 PDT

(In reply to comment #8) > Landed in r60201. Buildfix for this patch landed in r60221. ( build without ENABLE(RUBY) )

Note You need to log in before you can comment on or make changes to this bug.