Summary: | autoinstall DEBUG logging is too chatty | ||
---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | abarth, cjerdonek |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 |
Description
Eric Seidel (no email)
2010-05-24 13:38:51 PDT
These types of messages are actually really good for debugging autoinstall. Python's logging module is highly configurable. Rather than changing autoinstall's code, the way to handle this type of issue is to be more fine-grained when configuring logging from other applications. For example, you can use filters to disable autoinstall logging or to disable autoinstall logging below a certain level. I.e. make the DEBUG apply to anything but autoinstall. Let me see if I can dig up an example of filtering inside webkitpy. Check out this code which filters out autoinstall logging: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/test-webkitpy?rev=56981#L87 I believe the webkitpy configure_logging() function you call at the beginning of webkit-patch accepts a filter parameter to add filters that the caller wants added. If it doesn't, a parameter like that should probably be added. Make sure you only filter autoinstall logging for DEBUG or below though -- I think the INFO messages are good to keep. (In reply to comment #0) > Or maybe we shouldn't be trying to load all those different autoinstalled urls? This report would address the above aspect of things: https://bugs.webkit.org/show_bug.cgi?id=39223 |