Bug 39605

Summary:

restore r58765: notifications should have dir and replaceId attributes

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

johnnyg

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	dglazkov: review+

Dirk Pranke

Reported 2010-05-24 11:07:48 PDT

re-revert r58765

Attachments
Patch (13.88 KB, patch) 2010-05-24 11:08 PDT, Dirk Pranke	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2010-05-24 11:08:19 PDT

Created attachment 56905 [details] Patch

Dirk Pranke

Comment 2 2010-05-25 14:09:09 PDT

Re-commit r58765 - it had been rolled out to see if it was causing a perf regression (in r59787 and r59789), but that does not seem to have been the case. https://bugs.webkit.org/show_bug.cgi?id=38336 tracked the original bug ; https://bugs.webkit.org/show_bug.cgi?id=3928 tracked the revert.

Dimitri Glazkov (Google)

Comment 3 2010-05-25 14:09:57 PDT

Comment on attachment 56905 [details] Patch ok.

Dirk Pranke

Comment 4 2010-05-25 15:48:03 PDT

Committed r60193: <http://trac.webkit.org/changeset/60193>

Note You need to log in before you can comment on or make changes to this bug.