Bug 39604

Summary:

Remove custom bindings for Element.SetAttribute*

Product:

WebKit

Reporter:

Justin Schuh <jschuh>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Justin Schuh

Reported 2010-05-24 10:45:56 PDT

Removes: - Element.setAttribute() - Element.setAttributeNode() - Element.setAttributeNS() - Element.setAttributeNodeNS() Custom bindings are no longer needed because origin checks were moved out of the bindings by: http://trac.webkit.org/changeset/59866

Attachments
Patch (8.52 KB, patch) 2010-05-24 10:49 PDT, Justin Schuh	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Justin Schuh

Comment 1 2010-05-24 10:49:20 PDT

Created attachment 56903 [details] Patch

Nate Chapin

Comment 2 2010-05-24 16:44:43 PDT

Comment on attachment 56903 [details] Patch Deleting unnecessary code makes me smile :)

WebKit Commit Bot

Comment 3 2010-05-25 01:53:47 PDT

Comment on attachment 56903 [details] Patch Clearing flags on attachment: 56903 Committed r60148: <http://trac.webkit.org/changeset/60148>

WebKit Commit Bot

Comment 4 2010-05-25 01:53:51 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 5 2010-05-25 03:43:24 PDT

http://trac.webkit.org/changeset/60148 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/60148 http://trac.webkit.org/changeset/60149 http://trac.webkit.org/changeset/60150

Note You need to log in before you can comment on or make changes to this bug.