Bug 39604 - Remove custom bindings for Element.SetAttribute*
Summary: Remove custom bindings for Element.SetAttribute*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 10:45 PDT by Justin Schuh
Modified: 2010-05-25 03:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.52 KB, patch)
2010-05-24 10:49 PDT, Justin Schuh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Schuh 2010-05-24 10:45:56 PDT 
Removes:
- Element.setAttribute()
- Element.setAttributeNode()
- Element.setAttributeNS()
- Element.setAttributeNodeNS()

Custom bindings are no longer needed because origin checks were moved  out of the bindings by: 
http://trac.webkit.org/changeset/59866
Comment 1 Justin Schuh 2010-05-24 10:49:20 PDT 
Created attachment 56903 [details]
Patch
Comment 2 Nate Chapin 2010-05-24 16:44:43 PDT 
Comment on attachment 56903 [details]
Patch

Deleting unnecessary code makes me smile :)
Comment 3 WebKit Commit Bot 2010-05-25 01:53:47 PDT 
Comment on attachment 56903 [details]
Patch

Clearing flags on attachment: 56903

Committed r60148: <http://trac.webkit.org/changeset/60148>
Comment 4 WebKit Commit Bot 2010-05-25 01:53:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-05-25 03:43:24 PDT 
http://trac.webkit.org/changeset/60148 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/60148
http://trac.webkit.org/changeset/60149
http://trac.webkit.org/changeset/60150