Bug 39593

Summary: [Android] Add IndexedDB to the build
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch steveblock: review+

Jeremy Orlow
Reported 2010-05-24 05:56:42 PDT
[Android] Add IndexedDB to the build
Attachments
Patch (5.94 KB, patch)
2010-05-24 06:02 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (6.01 KB, patch)
2010-05-25 08:59 PDT, Jeremy Orlow 		steveblock: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-05-24 06:02:39 PDT
Created attachment 56877 [details] Patch
Jeremy Orlow
Comment 2 2010-05-25 07:20:06 PDT
Ping..
Steve Block
Comment 3 2010-05-25 08:09:26 PDT
Comment on attachment 56877 [details] Patch WebCore/Android.derived.jscbindings.mk:370 + $(intermediates)/storage/IndexedDatabaseRequest.h These should be JSIDBFoo.h WebCore/Android.derived.v8bindings.mk:351 + $(intermediates)/storage/IndexedDatabaseRequest.h These should be bindings/V8IDBFoo.h WebCore/Android.mk:730 + ifeq ($(ENABLE_INDEXED_DATABASE), true) No need for the guards, as the file contents are guarded anyway (the SVG guards are just a legacy thing)
Jeremy Orlow
Comment 4 2010-05-25 08:59:19 PDT
Created attachment 57023 [details] Patch
Steve Block
Comment 5 2010-05-25 09:03:58 PDT
Comment on attachment 57023 [details] Patch WebCore/Android.mk:739 + storage/StorageSyncManager.cpp Change not needed
Jeremy Orlow
Comment 6 2010-05-25 09:18:44 PDT
(In reply to comment #5) > (From update of attachment 57023 [details]) > WebCore/Android.mk:739 > + storage/StorageSyncManager.cpp > Change not needed Which is preferred? I looked and saw at least a couple cases where there was none at the end, so I assumed that was preferred.
Steve Block
Comment 7 2010-05-25 09:23:43 PDT
No trailing slash is preferred - just pointing out that this is no longer required for your patch.
Jeremy Orlow
Comment 8 2010-05-25 09:26:20 PDT
It's not clear from the diff, but that line is in the same block as the one I was adding to. I just noticed it and figured I'd clean it up as I went. It was never strictly required. But I think it makes the world a slightly better place.
Jeremy Orlow
Comment 9 2010-05-26 03:35:57 PDT
Committed r60228: <http://trac.webkit.org/changeset/60228>
Note You need to log in before you can comment on or make changes to this bug.