Summary: | Web Inspector: '?' and '/' typed at console prompt are not properly handled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, joepeck, kcbanner, keishi, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andrey Kosyakov
2010-05-24 02:29:53 PDT
Created attachment 56865 [details]
patch
Comment on attachment 56865 [details]
patch
WebCore/inspector/front-end/inspector.js:715
+ event.preventDefault();
why not return from here?
Created attachment 56867 [details]
patch
Indeed, we better return instantly upon catching our key. Thanks for spotting this -- it's been so for quite a few revisions!
> '?' and '/' invoke help screen even when typed at console prompt.
Why not mention that in ChangeLog? The current ChangeLog is super unhelpful - it tell neither what is fixed, nor how.
Comment on attachment 56867 [details] patch Clearing flags on attachment: 56867 Committed r60126: <http://trac.webkit.org/changeset/60126> All reviewed patches have been landed. Closing bug. |