Summary: | [DRT/Chromium] Import layout_test_helper for Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, hamaji, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Windows XP | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 35902 | ||||||
Attachments: |
|
Description
Kent Tamura
2010-05-23 23:21:23 PDT
Created attachment 56849 [details]
Patch ([build/include_order] error expected)
Attachment 56849 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/chromium/LayoutTestHelperWin.cpp:31: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 56849 [details]
Patch ([build/include_order] error expected)
ok.
Comment on attachment 56849 [details] Patch ([build/include_order] error expected) Clearing flags on attachment: 56849 Committed r60123: <http://trac.webkit.org/changeset/60123> All reviewed patches have been landed. Closing bug. |