Bug 39581 - [DRT/Chromium] Import layout_test_helper for Windows
Summary: [DRT/Chromium] Import layout_test_helper for Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35902
  Show dependency tree / graph
 
Reported: 2010-05-23 23:21 PDT by Kent Tamura
Modified: 2010-05-24 21:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch ([build/include_order] error expected) (5.55 KB, patch)
2010-05-23 23:25 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-05-23 23:21:23 PDT 
[DRT/Chromium] Import layout_test_helper for Windows
Comment 1 Kent Tamura 2010-05-23 23:25:48 PDT 
Created attachment 56849 [details]
Patch ([build/include_order] error expected)
Comment 2 WebKit Review Bot 2010-05-23 23:27:43 PDT 
Attachment 56849 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/chromium/LayoutTestHelperWin.cpp:31:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dimitri Glazkov (Google) 2010-05-24 07:28:05 PDT 
Comment on attachment 56849 [details]
Patch ([build/include_order] error expected)

ok.
Comment 4 Kent Tamura 2010-05-24 21:16:12 PDT 
Comment on attachment 56849 [details]
Patch ([build/include_order] error expected)

Clearing flags on attachment: 56849

Committed r60123: <http://trac.webkit.org/changeset/60123>
Comment 5 Kent Tamura 2010-05-24 21:16:21 PDT 
All reviewed patches have been landed.  Closing bug.