WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39581
[DRT/Chromium] Import layout_test_helper for Windows
https://bugs.webkit.org/show_bug.cgi?id=39581
Summary
[DRT/Chromium] Import layout_test_helper for Windows
Kent Tamura
Reported
2010-05-23 23:21:23 PDT
[DRT/Chromium] Import layout_test_helper for Windows
Attachments
Patch ([build/include_order] error expected)
(5.55 KB, patch)
2010-05-23 23:25 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2010-05-23 23:25:48 PDT
Created
attachment 56849
[details]
Patch ([build/include_order] error expected)
WebKit Review Bot
Comment 2
2010-05-23 23:27:43 PDT
Attachment 56849
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/chromium/LayoutTestHelperWin.cpp:31: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dimitri Glazkov (Google)
Comment 3
2010-05-24 07:28:05 PDT
Comment on
attachment 56849
[details]
Patch ([build/include_order] error expected) ok.
Kent Tamura
Comment 4
2010-05-24 21:16:12 PDT
Comment on
attachment 56849
[details]
Patch ([build/include_order] error expected) Clearing flags on attachment: 56849 Committed
r60123
: <
http://trac.webkit.org/changeset/60123
>
Kent Tamura
Comment 5
2010-05-24 21:16:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug