Bug 39552

Summary: webkit-patch should let you add a comment when uploading a patch
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2010-05-22 17:58:31 PDT
webkit-patch should let you add a comment when uploading a patch
Attachments
Patch (3.26 KB, patch)
2010-05-22 17:59 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.28 KB, patch)
2010-05-23 14:09 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-22 17:59:32 PDT
Created attachment 56802 [details] Patch Example comment
Daniel Bates
Comment 2 2010-05-22 18:00:47 PDT
Comment on attachment 56802 [details] Patch Awesome! Looks good to me.
WebKit Commit Bot
Comment 3 2010-05-23 05:59:16 PDT
Comment on attachment 56802 [details] Patch Rejecting patch 56802 from commit-queue. Failed to run "['WebKitTools/Scripts/test-webkitpy']" exit_code: 1 Last 500 characters of output: --\nMOCK: user.open_url: http://example.com/42\n' != 'Running check-webkit-style\nMOCK: user.open_url: file://...\nObsoleting 2 old patches on bug 42\nMOCK add_patch_to_bug: bug_id=42, description=MOCK description, mark_for_review=True, mark_for_commit_queue=False, mark_for_landing=False\n-- Begin comment --\nNone\n-- End comment --\nMOCK: user.open_url: http://example.com/42\n' ---------------------------------------------------------------------- Ran 447 tests in 8.616s FAILED (failures=2) Full output: http://webkit-commit-queue.appspot.com/results/2298501
Adam Barth
Comment 4 2010-05-23 14:09:20 PDT
Created attachment 56829 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-05-23 15:08:46 PDT
Comment on attachment 56829 [details] Patch for landing Clearing flags on attachment: 56829 Committed r60050: <http://trac.webkit.org/changeset/60050>
WebKit Commit Bot
Comment 6 2010-05-23 15:08:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.