Bug 39516

Summary: Add support for parsing the column-span property and getting it into computed style.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Dave Hyatt
Reported 2010-05-21 15:38:59 PDT
Back end support for column-span.
Attachments
Patch (10.44 KB, patch)
2010-05-21 15:40 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-05-21 15:40:05 PDT
Created attachment 56756 [details] Patch
WebKit Review Bot
Comment 2 2010-05-21 15:41:45 PDT
Attachment 56756 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/css/CSSParser.cpp:1489: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2010-05-21 15:43:14 PDT
Comment on attachment 56756 [details] Patch WebCore/css/CSSParser.cpp:1493 + validPrimitive = validUnit(value, FNumber | FNonNeg, m_strict) && value->fValue == 1.0; Current style for this is “1” instead of “1.0”. r=me
Dave Hyatt
Comment 4 2010-05-21 15:46:11 PDT
Fixed in r59968.
WebKit Review Bot
Comment 5 2010-05-21 16:24:32 PDT
http://trac.webkit.org/changeset/59968 might have broken GTK Linux 32-bit Release
Darin Adler
Comment 6 2010-05-25 13:45:52 PDT
This patch didn’t include a ChangeLog for the LayoutTests directory and only updated the Mac-specific expected results for the getComputedStyle test. I am landing a fix for the rest.
Note You need to log in before you can comment on or make changes to this bug.