Bug 39495

Summary: All callable objects should have a global object reference
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Patch ggaren: review+

Description Oliver Hunt 2010-05-21 09:54:07 PDT
All callable objects should have a global object reference
Comment 1 Oliver Hunt 2010-05-21 10:31:53 PDT
Created attachment 56726 [details]
Comment 2 Geoffrey Garen 2010-05-21 10:54:49 PDT
Comment on attachment 56726 [details]

Please mention your performance testing results in the ChangeLog.

+        All objects that may ever return a value other CallTypeNone
+        or ConstructTypeNone now get a global object in their constructor

Typo: Should be "other than".

Please fix EWS failures.

Since we can't use C++ subclassing, I wonder if there's some other centralized choke-point we can use for ensuring our anonymous slot contract. The ASSERT is good, but it would be better to catch an error even earlier, like at object construction time. For example, maybe we need a Structure::createCallable.

Comment 3 Oliver Hunt 2010-05-21 11:20:44 PDT
Committed r59941
Comment 4 Eric Seidel (no email) 2010-05-21 11:35:13 PDT
Broke the windows build.  My appologies that the win builder is not caught up yet.
Comment 5 WebKit Review Bot 2010-05-21 11:40:47 PDT
http://trac.webkit.org/changeset/59941 might have broken Qt Linux ARMv5 Release