| Summary: | caller of scheduleLocationChange in V8 binding and generic binding used the wrong signature | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Grace Kloba <klobag> | ||||||
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | android-webkit-unforking, commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
Created attachment 56669 [details]
Bug fix
Created attachment 56713 [details]
Fix the format issue in the previous patch
Comment on attachment 56713 [details]
Fix the format issue in the previous patch
Ok.
Comment on attachment 56713 [details] Fix the format issue in the previous patch Clearing flags on attachment: 56713 Committed r60036: <http://trac.webkit.org/changeset/60036> All reviewed patches have been landed. Closing bug. |
Both V8 binding and generic binding assumes scheduleLocationChange() has four inputs. Here is the code snippet frame->redirectScheduler()->scheduleLocationChange(completedUrl, referrer, false, userGesture); But it actually has five. See below. void scheduleLocationChange(const String& url, const String& referrer, bool lockHistory = true, bool lockBackForwardList = true, bool userGesture = false); This caused userGesture maps to lockBackForwardList and userGesture is always false. Patch is coming.