Bug 39452

Summary: caller of scheduleLocationChange in V8 binding and generic binding used the wrong signature
Product: WebKit Reporter: Grace Kloba <klobag>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Bug fix
none
Fix the format issue in the previous patch none

Grace Kloba
Reported 2010-05-20 15:32:44 PDT
Both V8 binding and generic binding assumes scheduleLocationChange() has four inputs. Here is the code snippet frame->redirectScheduler()->scheduleLocationChange(completedUrl, referrer, false, userGesture); But it actually has five. See below. void scheduleLocationChange(const String& url, const String& referrer, bool lockHistory = true, bool lockBackForwardList = true, bool userGesture = false); This caused userGesture maps to lockBackForwardList and userGesture is always false. Patch is coming.
Attachments
Bug fix (2.13 KB, patch)
2010-05-20 22:10 PDT, Grace Kloba 		no flags
DetailsFormatted DiffDiff
Fix the format issue in the previous patch (2.33 KB, patch)
2010-05-21 08:50 PDT, Grace Kloba 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grace Kloba
Comment 1 2010-05-20 22:10:42 PDT
Created attachment 56669 [details] Bug fix
Grace Kloba
Comment 2 2010-05-21 08:50:30 PDT
Created attachment 56713 [details] Fix the format issue in the previous patch
Nate Chapin
Comment 3 2010-05-21 09:13:02 PDT
Comment on attachment 56713 [details] Fix the format issue in the previous patch Ok.
WebKit Commit Bot
Comment 4 2010-05-23 02:52:42 PDT
Comment on attachment 56713 [details] Fix the format issue in the previous patch Clearing flags on attachment: 56713 Committed r60036: <http://trac.webkit.org/changeset/60036>
WebKit Commit Bot
Comment 5 2010-05-23 02:52:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.