Bug 39436

Summary: The 'prototype' property on generated Web IDL interfaces should be { DontDelete | ReadOnly }
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, commit-queue, dglazkov, eric, ggaren, jorlow, mjs, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch, JSC-only
none
Proposed patch, JSC-only none

Andreas Kling
Reported 2010-05-20 11:14:23 PDT
According to: http://www.w3.org/TR/WebIDL/#interface-object
Attachments
Proposed patch, JSC-only (6.46 KB, patch)
2010-05-20 11:15 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch, JSC-only (6.50 KB, patch)
2010-05-22 16:31 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-05-20 11:15:48 PDT
Created attachment 56611 [details] Proposed patch, JSC-only This patch is JSC-only (CodeGeneratorJS.pm) I'll need some help for the V8 version of this change.
Alexey Proskuryakov
Comment 2 2010-05-20 17:11:25 PDT
This sounds reasonable, but does it match other browsers? A specification alone is rarely a sufficient reason to make a change in WebKit.
Andreas Kling
Comment 3 2010-05-20 23:14:32 PDT
(In reply to comment #2) > This sounds reasonable, but does it match other browsers? It matches Firefox. Opera allows delete/overwrite. IE allows overwrite.
Alexey Proskuryakov
Comment 4 2010-05-21 10:11:13 PDT
CC'ing Sam and Maciej, who would probably be the ones to make this call.
Eric Seidel (no email)
Comment 5 2010-05-21 12:06:26 PDT
Comment on attachment 56611 [details] Proposed patch, JSC-only + Need a bug URL (OOPS!) Will cause the commit to fail, please update.
Andreas Kling
Comment 6 2010-05-22 16:31:13 PDT
Created attachment 56797 [details] Proposed patch, JSC-only Updated patch with bug URL.
Sam Weinig
Comment 7 2010-05-23 13:58:50 PDT
Comment on attachment 56797 [details] Proposed patch, JSC-only I like it. r=me.
Andreas Kling
Comment 8 2010-05-24 07:04:22 PDT
Comment on attachment 56797 [details] Proposed patch, JSC-only Removing cq? since the included test will fail on V8. Need some advice on how to proceed with this patch.
Alexey Proskuryakov
Comment 9 2010-05-24 09:09:24 PDT
Comment on attachment 56797 [details] Proposed patch, JSC-only The agreement is that V8 bindings is Google's sole responsibility, and others needn't invest any effort in them. You can find the discussion in webkit-dev archives.
WebKit Commit Bot
Comment 10 2010-05-24 20:55:25 PDT
Comment on attachment 56797 [details] Proposed patch, JSC-only Clearing flags on attachment: 56797 Committed r60119: <http://trac.webkit.org/changeset/60119>
WebKit Commit Bot
Comment 11 2010-05-24 20:55:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.